Expand all appearances of uint to unsigned int #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a build issue with musl libc found in Gentoo [1], where uint definition is not available in two places and simplest solution is to expand it to unsigned int. [1] https://bugs.gentoo.org/712624 Signed-off-by: Petr Vaněk <[email protected]>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Mar 15, 2022
Upstream-PR: tat/mimetic#27 Closes: https://bugs.gentoo.org/712624 Signed-off-by: Petr Vaněk <[email protected]>
This commit changes all uint to unsigned int as it was suggested in [1]. [1] tat#22 (comment) Signed-off-by: Petr Vaněk <[email protected]>
arkamar
changed the title
|
I decided to go with second option, I have changed it everywhere. |
jktjkt
approved these changes
Mar 16, 2022
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 21, 2022
Upstream-PR: tat/mimetic#27 Closes: https://bugs.gentoo.org/712624 Signed-off-by: Petr Vaněk <[email protected]> Closes: #24585 Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a build issue with musl libc found in Gentoo, where
uintdefinition is not available in two places and simplest solution is to expand it tounsigned int.