Skip to content

Commit

Permalink
fix(apple): list disconnected devices, reverts #247 (#265)
Browse files Browse the repository at this point in the history
From my latest tests we can use devicectl even if the device is disconnected, if we skip it, we end up using ios-deploy which won't work on latest iOS/macOS devices
  • Loading branch information
lucasfernog authored Dec 27, 2023
1 parent 855ed76 commit 01d52ca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changes/disconnected-devicectl.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"cargo-mobile2": patch
---

Use devicectl even if iOS device is disconnected.
1 change: 0 additions & 1 deletion src/apple/device/devicectl/device_list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ fn parse_device_list<'a>(json: String) -> Result<BTreeSet<Device<'a>>, DeviceLis
.into_iter()
.filter(|device| {
device.connection_properties.tunnel_state != "unavailable"
&& device.connection_properties.tunnel_state != "disconnected"
&& (device.hardware_properties.platform.contains("iOS")
|| device.hardware_properties.platform.contains("xrOS"))
})
Expand Down

0 comments on commit 01d52ca

Please sign in to comment.