fix(ios): do not provide arch on xcodebuild when running build and archive #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcodebuild specifies that when passed, the arch option will be used for every single target within the project / workspace. This can prevent more complex use cases where modifications have been made to the project's build settings. Rather than modifying the default behavior, offer a way to fallback to project configuration for those cases
lucasfernog
changed the title
|
Looks like we can safely remove the arch - I've been testing this on both my macbook (apple silicon) and mac mini (intel) |
lucasfernog
approved these changes
Aug 19, 2024
Merged
|
Great news ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcodebuild specifies that when passed, the arch option will be used for every single target rather than using the project's configuration:
This can prevent more complex use cases where modifications have been made to the project's build settings.
Rather than modifying the default behavior, offer a way to fallback to project configuration for those cases