fix: ignore log lines in avd_list, fix docs.rs build
#414
Conversation
Package Changes Through bbf9812There are 1 changes which include cargo-mobile2 with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| @@ -31,3 +31,9 @@ pub fn avd_list(env: &Env) -> Result<BTreeSet<Emulator>, Error> { | |||
| }) | |||
| .map_err(Error::ListAvdsFailed) | |||
| } | |||
|
|
|||
| fn is_emulator_log_line(name: &str) -> bool { | |||
| ["INFO |", "WARNING |", "ERROR |"] | |||
There was a problem hiding this comment.
| ["INFO |", "WARNING |", "ERROR |"] | |
| ["INFO", "WARNING", "ERROR"] |
just in case the tabulation changes between OS or some other formatting condition..
There was a problem hiding this comment.
I find that hard to change but if it ever does, we can always adapt later.
I included the space and |, to ensure that it is in fact a log line and not just weirdly named emulator, because you can name an emulator INFO but you can't have | in the name.
Maybe we can change the detection to check for | and that would be enough?
There was a problem hiding this comment.
just leave it as is then, they might also change the output layout in the future anyways
No description provided.