Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix regression in setting/getting inner size #1007

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Nov 11, 2024

fix tauri-apps/tauri#11644

  • Fix regression for decorated window, remove borders in inner_size only for undecorated window with shadows
  • Add borders when setting inner size for undecorated window with shadows

- Fix regression for decorated window, remove borders in `inner_size` only for undecorated window with shadows
- Add borders when setting inner size for undecorated window with shadows
@amrbashir amrbashir requested a review from a team as a code owner November 11, 2024 13:19
Copy link
Contributor

Package Changes Through e833336

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.30.6 0.30.7

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not tested myself - edit: tell me if i should)

@amrbashir
Copy link
Member Author

I will merge so I can release the fix, but give it a test and see if you spot any issue

@amrbashir amrbashir merged commit 9738223 into dev Nov 11, 2024
9 checks passed
@amrbashir amrbashir deleted the fix/windows-inner-size-regressions branch November 11, 2024 13:46
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
@FabianLars
Copy link
Member

seems to work fine, couldn't find a config combination with the issue anymore👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Incorrect height returned for innerSize on Windows since 2.1.0
2 participants