Changed to activate before opening window on macos. #445
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Jun 23, 2022
keiya01
reviewed
Jun 23, 2022
islandryu
changed the title
islandryu
commented
Jun 26, 2022
src/platform_impl/macos/app_state.rs
Outdated
Comment on lines
288
to
294
| // In catalina, if we set the activation policy before the app is launched, | ||
| // We get a bug where the menu is not clickable. | ||
| // We have solved this problem by setting the activation policy to prohibited | ||
| // with `set_policy_to_prohibited` and then running `apply_activation_policy` again. | ||
| set_policy_to_prohibited(); | ||
| apply_activation_policy(app_delegate); |
There was a problem hiding this comment.
@amrbashir @keiya01
I checked the operation in catalina and the menu bar was not clickable in the previous commit.
It is not a fundamental solution, but once I set the activation policy to prohibit and then run apply_activation_policy again, I can click on the menu bar.
output.compress-video-online.com.mp4
There was a problem hiding this comment.
I will leave this for @wusyong to approve. He is the macOS expert.
There was a problem hiding this comment.
Sorry, I totally forgot this issue :(
I'm on Ventura now and this PR couldn't solve it.
Tested with winit and it also has this issue.
If anyone knows what's the latest way to fix it, please let us know.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
fix tauri-apps/tauri#4310
Fixed a bug that when starting tao with cargo run on macos, it was activated after the window was opened.
before fixed
1.mov
after fixed
2022-06-23.14.22.41.1.mov