Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optimize Covector Config #945

Merged
merged 2 commits into from
Jun 30, 2024
Merged

chore: Optimize Covector Config #945

merged 2 commits into from
Jun 30, 2024

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Jun 26, 2024

Motivation

We have made some quality-of-life updates to covector. I am optimizing the config to take advantage of these changes.

Changes

  • use fetch:check to query the crate API instead of command which should be less brittle
  • remove extra code block backticks on publish
  • remove cargo package as we no longer want to publish .crate to the GitHub Release

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Package Changes Through 22ff523

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.28.1 0.28.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@jbolda
Copy link
Member Author

jbolda commented Jun 26, 2024

Note that we might be able to remove the cargo package based on our current practices, but living this in draft until we decide.

@jbolda jbolda marked this pull request as ready for review June 29, 2024 05:36
@jbolda jbolda requested a review from a team as a code owner June 29, 2024 05:36
@amrbashir amrbashir merged commit f429dbd into dev Jun 30, 2024
9 checks passed
@amrbashir amrbashir deleted the optimize-covector-config branch June 30, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants