Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make app_dir() logic consistent #10418

Merged
merged 5 commits into from
Aug 11, 2024

Conversation

samkearney
Copy link
Contributor

Fixes #10417. See that issue description for more details.

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Package Changes Through 40e3aba

There are 6 changes which include tauri-build with prepatch, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@samkearney samkearney force-pushed the cli-make-app-dir-consistent branch 3 times, most recently from e94c754 to 145d936 Compare July 31, 2024 18:02
@samkearney
Copy link
Contributor Author

Sorry for the back and forth on CI, I don't have a macOS machine to test with 😅

@samkearney samkearney force-pushed the cli-make-app-dir-consistent branch from be44a65 to eb40a2e Compare August 2, 2024 13:41
…cation directory rather than the current working directory
@samkearney samkearney force-pushed the cli-make-app-dir-consistent branch from cec0c5a to f1a44d9 Compare August 8, 2024 14:54
lucasfernog
lucasfernog previously approved these changes Aug 11, 2024
@lucasfernog lucasfernog merged commit 2d47352 into tauri-apps:dev Aug 11, 2024
18 of 19 checks passed
lucasfernog added a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] CLI cannot find app_dir in a subdirectory of current working directory with some commands (inconsistent)
2 participants