Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bundler&cli MSRV #10499

Merged
merged 22 commits into from
Aug 8, 2024
Merged

fix: Fix bundler&cli MSRV #10499

merged 22 commits into from
Aug 8, 2024

Conversation

FabianLars
Copy link
Member

I added the bundler and cli to the msrv check and while trying to downgrade all the crates to the bundler's MSRV (1.60) it appeared that the bundler and cli were effectively already on 1.70/1.71 (both in code syntax and cargo.toml deps) and downgrading them required more changes than i'd like to do.

Therefore this isn't really a breaking change and imo should be fine to be part of a simple patch release.
1.70 is a bit over 1 year old now.

The bundler and cli msrv checks are seperate because a) i tried to adhere to 1.60 for the bundler first and b) we bump the cli msrv more often at which point a seperate check will be required anyway.

@FabianLars FabianLars requested a review from a team as a code owner August 5, 2024 17:15
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Package Changes Through 98ab0a9

There are 9 changes which include tauri with patch, tauri-codegen with patch, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-utils with patch, tauri-build with patch, tauri-runtime with patch, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 1.6.0 1.6.1
tauri-bundler 1.6.0 1.6.1
tauri-runtime 0.14.4 0.14.5
tauri-runtime-wry 0.14.9 0.14.10
tauri-codegen 1.4.4 1.4.5
tauri-macros 1.4.5 1.4.6
tauri-build 1.5.3 1.5.4
tauri 1.7.1 1.7.2
@tauri-apps/cli 1.6.0 1.6.1
tauri-cli 1.6.0 1.6.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

FabianLars commented Aug 5, 2024

I'll be afk for a few hours so if any of the ci checks fail i'll need a while to fix them nevermind, see ya tomorrow (CI is happy any way)

@lucasfernog lucasfernog merged commit 297cd55 into 1.x Aug 8, 2024
29 checks passed
@lucasfernog lucasfernog deleted the v1/msrv-check branch August 8, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants