refactor(bundler/nsis): replace nsis_process.dll usage with nsProcess.dll
#11041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nsis_process` dll is written by us in https://github.com/tauri-apps/nsis-tauri-utils but anti virus tools picks it up as virus. Its code does as much as `nsProcess` but I guss we just don't have enough popularity as `nsProcess` has with anti-virus tools. closes tauri-apps/nsis-tauri-utils#39 ref: tauri-apps/nsis-tauri-utils#37
amrbashir
changed the title
nsis_process.dll usage with nsProcess.dll
Package Changes Through 1b45256No changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
commented
Sep 18, 2024
|
I don't like this to be honest, if this is a webroot only problem, can we contact them to white list us instead? |
|
I don't like it either but I am not sure how many more anti virus would have false positives. Also weirdly enough, [email protected] passes all anti viruses https://www.virustotal.com/gui/url/e814a313d4ba77fd51c3d1408c3ba49329a52656a767df50bdcbb867bcf837f6?nocache=1 |
|
Converting to a draft for now |
|
should be fixed with #11676 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nsis_processdll is written by us in https://github.com/tauri-apps/nsis-tauri-utils but anti virus tools picks it up as virus. Its code does as much asnsProcessbut I guss we just don't have enough popularity asnsProcesshas with anti-virus tools.closes tauri-apps/nsis-tauri-utils#39
closes: tauri-apps/nsis-tauri-utils#37