refactor(core&cli): activate default features in build script instead of CLI #11098
Conversation
Package Changes Through 0acf0e5There are 3 changes which include tauri with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
changed the title
| // and `cargo build --release` same as `tauri build` | ||
| // but for `tauri build --debug` we need to build the code | ||
| // in `debug` profile and activate `custom-protocol` feature. | ||
| if !dev && options.debug && !has_custom_profile { |
There was a problem hiding this comment.
| if !dev && options.debug && !has_custom_profile { | |
| if !dev { |
if the custom profile is a debug one we still want to force the feature flag
There was a problem hiding this comment.
i'm not sure if we can actually use this..
from the docs (https://doc.rust-lang.org/cargo/reference/build-scripts.html#rustc-cfg):
Note that this does not affect Cargo’s dependency resolution. This cannot be used to enable an optional dependency, or enable other Cargo features.
and the TLS features all must enable optional dependencies from reqwest...
|
ngl this feels super over engineered to me anyway. I don't think the old way was that bad, we should just mention the feature flag somewhere |
|
:sadge: I guess we will have to use custom logic in tauri-cli for now |
No description provided.