Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use_https_scheme for Windows and Android #11477

Merged
merged 11 commits into from
Nov 5, 2024

Conversation

amrbashir
Copy link
Member

closes #11252

@amrbashir amrbashir requested a review from a team as a code owner October 24, 2024 08:00
Copy link
Contributor

github-actions bot commented Oct 24, 2024

Package Changes Through eda3f1d

There are 8 changes which include tauri with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-runtime-wry with minor, @tauri-apps/api with patch, tauri-utils with minor, tauri-runtime with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.3 2.0.4
tauri-utils 2.0.2 2.1.0
tauri-bundler 2.0.4 2.1.0
tauri-runtime 2.1.1 2.2.0
tauri-runtime-wry 2.1.2 2.2.0
tauri-codegen 2.0.2 2.0.3
tauri-macros 2.0.2 2.0.3
tauri-plugin 2.0.2 2.0.3
tauri-build 2.0.2 2.0.3
tauri 2.0.6 2.1.0
@tauri-apps/cli 2.0.4 2.1.0
tauri-cli 2.0.4 2.1.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to apply the suggestions, i know it's easier to do locally (esp since you have to regen the schema).

Also this part

Changing this value between releases will change the IndexedDB, cookies and localstorage location and your app will not be able to access them.

is a bit off, i have to assume that the last part will be interpreted as "no indexeddb access at all" by a few non native speakers.

What about something simple like this?

Changing this value between releases will change the IndexedDB, cookies and localstorage location and your app will not be able to access the old data.

crates/tauri-runtime/src/webview.rs Outdated Show resolved Hide resolved
crates/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
crates/tauri/src/webview/mod.rs Outdated Show resolved Hide resolved
crates/tauri/src/webview/webview_window.rs Outdated Show resolved Hide resolved
packages/api/src/webview.ts Outdated Show resolved Hide resolved
FabianLars
FabianLars previously approved these changes Nov 4, 2024
@FabianLars
Copy link
Member

for the migration: what about the dangerousUseHttpsScheme config? Since it's marked dangerous i wouldn't mind ignoring it, just asking in case you forgot that config.

@amrbashir
Copy link
Member Author

will add that as well

FabianLars
FabianLars previously approved these changes Nov 4, 2024
lucasfernog
lucasfernog previously approved these changes Nov 5, 2024
@amrbashir amrbashir requested a review from lucasfernog November 5, 2024 12:22
@lucasfernog lucasfernog merged commit f37e97d into dev Nov 5, 2024
29 checks passed
@lucasfernog lucasfernog deleted the feat/use-https-scheme branch November 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] [v2] IndexedDB path changed after upgrading to tauri 2
3 participants