feat: Implement Badging API #11661
Merged
feat: Implement Badging API #11661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahqsoftwares
changed the title
set_badge_count, set_badge_label, _set_overlay_icon`, closes #489set_badge_count, set_badge_label, _set_overlay_icon`, closes #4489
ahqsoftwares
changed the title
set_badge_count, set_badge_label, _set_overlay_icon`, closes #4489set_badge_count, set_badge_label, set_overlay_icon, closes #4489
Package Changes Through d094a46There are 8 changes which include tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, @tauri-apps/api with minor, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
ahqsoftwares
changed the title
set_badge_count, set_badge_label, set_overlay_icon, closes #4489
ahqsoftwares
changed the title
ahqsoftwares
changed the title
amrbashir
requested changes
Nov 14, 2024
amrbashir
reviewed
Nov 14, 2024
amrbashir
requested changes
Nov 14, 2024
packages/api/src/window.ts
Outdated
Comment on lines
2347
to
2351
| name: m.name, | ||
| scaleFactor: m.scaleFactor, | ||
| position: new PhysicalPosition(m.position), | ||
| size: new PhysicalSize(m.size) | ||
| } |
There was a problem hiding this comment.
It was actually done by prettier
There was a problem hiding this comment.
looks like something is wrong on your setup, as CI was failing because of this
amrbashir
requested changes
Nov 19, 2024
amrbashir
approved these changes
Nov 20, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4489
This PR implements badging api for Windows, macOS, Linux, IOS from tao upstream ref #1002