Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/tray): add TrayIcon.setShowMenuOnLeftClick method #11726

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Nov 18, 2024

Followup to #11729:

  • Deprecate setMenuOnLeftClick and Add setShowMenuOnLeftClick to match Rust API.
  • Make docs consistent
  • Format some run_item_main_thread macro usages

@amrbashir amrbashir requested a review from a team as a code owner November 18, 2024 17:09
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Package Changes Through dbdfdce

There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.1.1 2.2.0
tauri-utils 2.1.0 2.1.1
tauri-bundler 2.1.0 2.2.0
tauri-runtime 2.2.0 2.3.0
tauri-runtime-wry 2.2.0 2.3.0
tauri-codegen 2.0.3 2.0.4
tauri-macros 2.0.3 2.0.4
tauri-plugin 2.0.3 2.0.4
tauri-build 2.0.3 2.0.4
tauri 2.1.1 2.2.0
@tauri-apps/cli 2.1.0 2.2.0
tauri-cli 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir changed the title feat: add support for menu_on_left_click on Windows feat: add setShowMenuOnLeftClick Nov 18, 2024
@amrbashir amrbashir changed the title feat: add setShowMenuOnLeftClick feat(api/tray): add TrayIcon.setShowMenuOnLeftClick method Nov 18, 2024
@FabianLars
Copy link
Member

shouldn't the builder methods be renamed too then?

@amrbashir
Copy link
Member Author

yeah, didn't notice that one

FabianLars
FabianLars previously approved these changes Nov 20, 2024
@amrbashir amrbashir merged commit fc30b20 into dev Nov 21, 2024
32 checks passed
@amrbashir amrbashir deleted the feat/windows-menu-on-left-click branch November 21, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants