fix(core): manually simplify patterns for fs scope #11730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #11614 Remove UNC manually, instead of `dunce::simplified` because `path` could have `*` in it and that's not allowed on Windows and `dunce::simplified` will check that and return `path` as is without simplification resulting in a missing pattern in scope for the scope pattern `\\?\C:\path\to\dir\**`, we expect the scope to have: - `\\?\C:\path\to\dir\**` - `C:\path\to\dir\**` but if we use `dunce::simplified`, it will see `**` as invalid path component on Windows and will not simplify the path resulting in a scope that only has `\\?\C:\path\to\dir\**`
Package Changes Through b1163a2There are 8 changes which include tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, @tauri-apps/api with patch, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11614
Remove UNC manually, instead of
dunce::simplifiedbecausepathcould have*in it and that's not allowed on Windows anddunce::simplifiedwill check that and returnpathas is without simplification resulting in a missing pattern in scopefor the scope pattern
\\?\C:\path\to\dir\**, we expect the scope to have:\\?\C:\path\to\dir\**C:\path\to\dir\**but if we use
dunce::simplified, it will see**as invalid path component on Windows and will not simplify the path resulting in a scope that only has\\?\C:\path\to\dir\**