Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI/clippy): Address clippy errors in CI #11872

Conversation

johncarmack1984
Copy link
Contributor

@johncarmack1984 johncarmack1984 commented Dec 4, 2024

This PR resolves clippy errors when running locally and in CI, allowing checks to pass.

…e in linux bundler; erase empty else branch causing warning in macOS bundler
@johncarmack1984 johncarmack1984 requested a review from a team as a code owner December 4, 2024 19:00
@FabianLars
Copy link
Member

Thanks, both of those were fixed by Lucas in #11694 already. Since the appimage.rs fix here is wrong-ish i'll close it in favor of that one (it was supposed to be merged already)

@FabianLars FabianLars closed this Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Package Changes Through 9d2a602

There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.1.1 2.2.0
tauri-utils 2.1.0 2.1.1
tauri-bundler 2.1.0 2.2.0
tauri-runtime 2.2.0 2.3.0
tauri-runtime-wry 2.2.0 2.3.0
tauri-codegen 2.0.3 2.0.4
tauri-macros 2.0.3 2.0.4
tauri-plugin 2.0.3 2.0.4
tauri-build 2.0.3 2.0.4
tauri 2.1.1 2.2.0
@tauri-apps/cli 2.1.0 2.2.0
tauri-cli 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@johncarmack1984
Copy link
Contributor Author

@FabianLars cool cool! Anything I should do to get the checks on #11871 to pass? Or just wait for that PR to get merged and try again?

@FabianLars
Copy link
Member

yeah just wait or even ignore it since the rest of the lint was successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants