Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add id option for tray icon in config file #7871

Merged
merged 7 commits into from
Oct 3, 2023
Merged

feat: add id option for tray icon in config file #7871

merged 7 commits into from
Oct 3, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 20, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 20, 2023 20:57
lucasfernog
lucasfernog reviewed Oct 3, 2023
View reviewed changes
core/tauri/src/app.rs Outdated Show resolved Hide resolved
lucasfernog
lucasfernog reviewed Oct 3, 2023
View reviewed changes
core/tauri/src/app.rs Outdated Show resolved Hide resolved
lucasfernog
lucasfernog previously approved these changes Oct 3, 2023
View reviewed changes
@lucasfernog lucasfernog merged commit b597aa5 into dev Oct 3, 2023
31 checks passed
@lucasfernog lucasfernog deleted the feat/tray-icon-id-configuration branch October 3, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog