Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add beforeEachBundleCommand #7880

Closed
wants to merge 3 commits into from

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 21, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 21, 2023 05:41
@FabianLars
Copy link
Member

What's the use case for this? Or rather, what's the issue with the current beforeBundleCommand?

@amrbashir
Copy link
Member Author

This is allows for some conditional logic based on which package type is being bundled.

Also maybe we should also add beforeEachTargetBuildCommand? but I don't see a use-case for it immediately, and probably will only affect when building for Android as it has more than one target being built in the same invoke of tauri android build?

I don't really think this PR is urgent or needed that much so I am fine to just keep it open until someone requests it or close it.

@FabianLars
Copy link
Member

Ahh okay, my bad, i missed the TAURI_BUNDLER_PACKAGE_TYPE at the bottom (it's missing in the config description). Totally get it then 👍

@amrbashir
Copy link
Member Author

good catch, I will add it to the docs

@amrbashir amrbashir closed this Oct 18, 2023
@amrbashir
Copy link
Member Author

Closing until we see a use-case for this

@amrbashir amrbashir deleted the feat/bundler/before-each-bundle-command branch October 18, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants