Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): do nothing in clearMocks if __TAURI_INTERNALS__ is not defined #8071

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

G07cha
Copy link
Contributor

@G07cha G07cha commented Oct 20, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Prevents tests that didn't define any mocks from failing in afterEach test hook.

@G07cha G07cha requested a review from a team as a code owner October 20, 2023 14:12
Prevents tests that didn't define any mocks from failing in `afterEach` test hook.
@G07cha G07cha force-pushed the fix/clear-mocks-noop branch from 01a01b3 to ba1d805 Compare October 20, 2023 16:26
@lucasfernog lucasfernog merged commit 287066b into tauri-apps:dev Oct 21, 2023
9 checks passed
@G07cha G07cha deleted the fix/clear-mocks-noop branch October 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants