feat(core): add tracing for vital functionality closes #5204 #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKruckenberg
requested changes
Nov 22, 2023
amrbashir
requested changes
Nov 22, 2023
Co-authored-by: Amr Bashir <[email protected]>
Co-authored-by: Amr Bashir <[email protected]>
amrbashir
previously approved these changes
Nov 23, 2023
amrbashir
previously approved these changes
Nov 23, 2023
JonasKruckenberg
approved these changes
Nov 27, 2023
amrbashir
pushed a commit
that referenced
this pull request
Jan 16, 2024
* feat(tracing): add IPC tracing * span for deserialization * trace spans for IPC command handlers * fix spans usage * app tracing [skip ci] * window tracing * fix run never resolving all spans * fix draw not entered * change level * feat(core): Manager::emit_filter and optimize serialization (#7512) Co-authored-by: Lucas Nogueira <[email protected]> * event spans * lint & fix tests * change eval to run sync * fix instrument * update wry * change separator * Update core/tauri/src/plugin.rs Co-authored-by: Jonas Kruckenberg <[email protected]> * Update core/tauri/src/window.rs Co-authored-by: Jonas Kruckenberg <[email protected]> * Update core/tauri/src/window.rs Co-authored-by: Jonas Kruckenberg <[email protected]> * Update core/tauri/src/window.rs Co-authored-by: Jonas Kruckenberg <[email protected]> * Update core/tauri/src/window.rs Co-authored-by: Jonas Kruckenberg <[email protected]> * instrument separators * remove on_event trace * skip all arguments on App::build tracing * ipc spans adjustments * delete change file * improve how request and response are added as values (serialize) * do not run evalScript sync on android :( freezes the app * wry 0.35.2 * add change file --------- Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: Jonas Kruckenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Adds tracing to the most important Tauri interfaces (IPC, custom protocol request handling, event system, updater, JS eval, window creation, plugins).
Needs tauri-apps/wry#1093