fix: log postmessage errors (#1426)

tauri-apps · Dec 31, 2024 · b4ba5b4 · b4ba5b4
1 parent 4740c0b
commit b4ba5b4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/.changes/postmessage-assert-panic.md b/.changes/postmessage-assert-panic.md
@@ -0,0 +1,5 @@
+---
+"wry": "patch"
+---
+
+On Windows, Wry will now log PostMessage errors instead of panicking.
diff --git a/src/webview2/mod.rs b/src/webview2/mod.rs
@@ -1040,11 +1040,20 @@ impl InnerWebView {
 
     let raw = Box::into_raw(boxed2);
 
-    let res = PostMessageW(hwnd, *EXEC_MSG_ID, WPARAM(raw as _), LPARAM(0));
-    assert!(
-      res.is_ok(),
-      "PostMessage failed ; is the messages queue full?"
-    );
+    let _res = PostMessageW(hwnd, *EXEC_MSG_ID, WPARAM(raw as _), LPARAM(0));
+
+    #[cfg(any(debug_assertions, feature = "tracing"))]
+    if let Err(err) = _res {
+      let msg = format!(
+        "PostMessage failed ; is the messages queue full? Error code {} - {}",
+        err.code(),
+        err.message()
+      );
+      #[cfg(feature = "tracing")]
+      tracing::error!("{}", &msg);
+      #[cfg(debug_assertions)]
+      eprintln!("{}", msg);
+    }
   }
 
   unsafe extern "system" fn main_thread_dispatcher_proc(