fix(linux): don't share UserContentManager between webviews (v0.24) #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through c3900d7There are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Fixes tauri-apps#1308 Init scripts are registered to the UserContentManager, so if it is shared between webviews, the init scripts will conflict. Use a unique UserContentManager for each WebView instead of sharing it across the WebContext. The IPC message handler is also registered to UserContentManager. window_hash is no longer needed as a key to register_script_message_handler since the manager is unique. window_hash is already removed on the dev branch.
Change from register_uri_scheme to try_register_uri_scheme, which doesn't attempt to register if we already know that one with the same name was registered to the WebContext before. Without this change, I get this error from WebKitGTK: ** (tauri-app:[...]): CRITICAL **: 14:03:50.040: Cannot register URI scheme tauri more than once It doesn't seem to affect functionality, but better to issue a more appropriate warning on our side.
ollpu
force-pushed
the
multiwindow-shared-context-v0.24
branch
from
e4ab3d4 to
d119e20
Compare
ollpu
commented
Jul 25, 2024
amrbashir
approved these changes
Aug 21, 2024
amrbashir
reviewed
Aug 21, 2024
amrbashir
reviewed
Aug 21, 2024
amrbashir
reviewed
Aug 21, 2024
|
@amrbashir Hold on, there is still manager.register_script_message_handler("ipc");so referencing by the window hash in the init script won't work, right? Otherwise this is ok by me, but how was it a breaking change? |
ollpu
added a commit
to ollpu/wry
that referenced
this pull request
Aug 22, 2024
Fallout from changes done to tauri-apps#1325 before merging
amrbashir
pushed a commit
that referenced
this pull request
Aug 22, 2024
Fallout from changes done to #1325 before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1308
Init scripts are registered to the
UserContentManager, so if it is shared betweenWebViews, the init scripts conflict. Use a uniqueUserContentManagerfor eachWebViewinstead of sharing it across theWebContext.The IPC message handler is also registered to
UserContentManager.window_hashis no longer needed as a key toregister_script_message_handlersince the manager is unique. (window_hashis already removed on the dev branch.)Also changed from
register_uri_schemetotry_register_uri_scheme, which doesn't attempt to register a URI scheme if we already know that one with the same name was registered to theWebContextbefore. Without this change, I get this error from WebKitGTK:It doesn't seem to affect functionality, but better to issue a more appropriate warning on our side. (On dev, this is propagated as an error)
Corresponding PR on the dev branch: #1326