fix(android): skip duplicated Content-Type/Content-Length header to fix tauri-apps/tauri#8857 #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 87d8da5There are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Sep 10, 2024
| @@ -216,6 +216,9 @@ fn handle_request( | |||
| let response_headers = { | |||
| let headers_map = JMap::from_env(env, &obj)?; | |||
| for (name, value) in headers.iter() { | |||
| if name == CONTENT_TYPE || name == CONTENT_LENGTH { | |||
There was a problem hiding this comment.
let's add a comment to explain why we are skipping these
There was a problem hiding this comment.
It's added now :D
amrbashir
approved these changes
Sep 10, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title follows, currently Android binding need to pass
Content-Typeseparately when creatingWebResourceReponseobjects, but theresponse_headersdoesn't skipContent-TypeandContent-Lengthheaders, which will be append into auto-generated headers with comma, which causes issue tauri-apps/tauri#8857 (e.g.application/wasmbecomesapplication/wasm, application/wasm)This PR fixed it by adding single conditional statement to skip these headers inside for loop when putting header into objects.