Improve custom URL scheme handler robustness #1440
Open
+82
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
wry_web_view.rs/get_custom_task_uuid
trying to access staleWryWebView
.This happens sometimes when closing a
WebviewWindow
or callingwin.close()
. It causes a runtime panic and crashes the application when it occurs. Fixed by adding runtime checks to make surewebview_id
andtask_uuid
are valid before they are used.Potentially related: #1425.