-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add traffic light inset #1446
Conversation
Package Changes Through 17f5bb8There are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
i will open the tauri pr tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the options seemed to conflict with with_decoration
in Tao. I think we should mention that the app would panic if the title bar doesn't exist.
Another question is whether the setting works on multiple monitors with different DPI?
It looks good on different DPI
Oh yes, absolutely. It requires a hidden title setting (which also means decorations are required). I meant to |
Hi, I am the original guy who tried to work on this. I have no idea what you did to fix this but I thank you deeply from my heart. I just couldn't look at this mess any longer without becoming anxious 😅 More importantly: I have lost track of this whole thing. Does my my kind of broken inset method still exist in Tao? If yes we should probably remove it right? |
I couldn't have done it without you 🫂 And no, we still need the Tao method. The method is also no broken (after all i use the very same impl here). It's still needed if the webview is injected via build_as_child (for multiwebview support for example). We probablyyy could overwrite this here as well, but imo windowing stuff should stay in the windowing library as much as possible. |
fixes #1056
I really wanted to fix this in tao or maybe in tauri but i just wasn't able to fix it in tao and in tauri it would have resulted in much more code (overwriting delegates and shit, see tauri-apps/tauri#4789