fix(windows): Fix the issue where TAB cannot cycle through focus elements. #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 46621fcThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Signed-off-by: SmileSky <[email protected]>
Signed-off-by: SmileSky <[email protected]>
FabianLars
reviewed
Jan 14, 2025
| @@ -176,6 +176,16 @@ impl InnerWebView { | |||
| wparam: WPARAM, | |||
| lparam: LPARAM, | |||
| ) -> LRESULT { | |||
| if msg == WM_SETFOCUS { | |||
| // Fix https://github.com/DioxusLabs/dioxus/issues/2900 | |||
| // Get the first child window of the window | |||
There was a problem hiding this comment.
This doesn't sound like the correct behavior for multiwebview windows but i don't reallyyy care about that at the moment and it's still better than losing focus completely.
FabianLars
approved these changes
Jan 14, 2025
|
Yes, I will further fix the focus issue with multiwebview windows in the future, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue, which is discussed here:
Specifically, when a user switches focus within a web element using the keyboard's tab, if they continue to press the tab after switching to the last web element, the focus will jump to the control with the class name WRY_WEBVIEW. At this point, no matter how much they press the tab, they cannot continue switching web elements;
The solution to this problem is to first switch to another application (such as the desktop), and then switch to the dioxus application again. At this point, the system will reset the focus to the web document, and you can continue to use the tab to switch elements, but this requires the user to operate it themselves, and the experience is very poor.
Expected behavior
The control with the class name WRY_WEBVIEW should not be allowed to grab keyboard focus, so that the tab key can be used to cyclically switch web elements.