Drop GCC 11 #220
Merged
Drop GCC 11 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 11 doesn't support C++20 constexpr allocations, and its ranges implementation is missing the backported `view` concept changes allowing you to pass rvalue non-views into range adaptors. It's becoming a bit frustating keep re-writing tests to support it, so this PR drops support. Note that we only ever supported GCC 11.3+ anyway, so this isn't a huge leap forward. We're still supporting the last three major versions.
tcbrindle
force-pushed
the
pr/drop-gcc11
branch
from
a708158
to
ee9a8a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 69 69
Lines 2578 2578
=======================================
Hits 2542 2542
Misses 36 36 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 11 doesn't support C++20 constexpr allocations, and its ranges implementation is missing the backported
viewconcept changes allowing you to pass rvalue non-views into range adaptors. It's becoming a bit frustating keep re-writing tests to support it, so this PR drops support.Note that we only ever supported GCC 11.3+ anyway, so this isn't a huge leap forward. We're still supporting the last three major versions.