add github workflow for CYGWIN-like platform MSYS2 on Windows #9

jannick0 · 2020-11-29T15:18:16Z

This commit series serves the purpose to prepare for and add a github workflow for MSYS(2), a CYGWIN-like environment on Windows. It compiles fine, but reveals many test failures to be fixed.

NB:

The entanglement with the win dir appears to be unneccassary and thus is removed to allow a pure unix configuration and build for MSYS and CYGWIN.
As of now there are many failing tests, while one test (io-53.4.1) is omitted since it hangs as of now.
For reference as to how CYGWIN and MSYS2 see need for heavily patching the tcl package which effectively ignore most of the #ifdef __CYGWIN__ branches. I believe that MSYS2 mostly relies on the CYGWIN patch.
The msys2 workflow file added by the top of this branch is meant to be copied to the windows workflow (after testing)

I hope it is OK that this is a Github PR since this is about a github workflow which should be automatically triggered when opening this PR.

…HANNEL_VERSION_5. Not actually a change, since supported procs are the same. So all internal channels have the same type

…ently) shadowing variable names

…tring is list" & length %2 == 0 to check for a valid dict

…s works for plain 8.6 too

Fix some more warnings, discovered in c20/c++20 mode

* unix/tcl.m4: add 'MSYS_' whenever 'CYGWIN_' * unix/configure: same here.

The env variable MSYSTEM is used in the CYGWIN-like MSYS shell governing the underlying platform type.

The removed code block is generated by the autoconf (2.69) macro AC_ARG_ENABLE. So let's remove it since it works as an idempotent. * unix/tcl.m4: here. * unix/configure: same. * win/tcl.m4: here. * win/configure: same.

The entanglement is unneccessary and rather confusing. * unix/tcl.m4: - remove call of win/configure when builing a shared CYGWIN library * unix/configure: same. * unix/Makefile.in: - remove call of make target 'winextensions' in dir 'win'

* unix/tcl.m4: - use cpp macro condition 'INTPTR_MAX == INT64_MAX' to portably check if platform is 64-bit. * unix/configure: same.

This github workflow is meant to be copied to the windows workflow file. NB: Ignore io-53.4.1 which currently hangs.

nijtmans · 2020-11-30T10:39:29Z

There's a "msys2-fixes-v001" branch in fossil now, with your PR. Two changes went right in Tcl now, the additional MSYSTEM environmentvariable, and the MSYS_ prefix in tcl.4: those don't harm any for the other platforms.

The entanglement with the "win" directory is only used to build the dde and registry extension. Although those 2 extensions are win32, they work fine with cygwin (and should work fine with msys2 too). Using dde, cygwin Tcl interpreters can communicate with win32 Tcl intepreters, that's usefull. And using registry, cygwin Tcl interpreters and access the Windows registry. I think that's usefull to keep, and is 100% separate from the build in the /unix directory.

Automatically determine --enable-64bit is a good idea, but it doesn't work yet together with the 'entaglement' with the "win" directory. Therefore I didn't take it over yet.

It's a pity that so many testcases still fail. This shows that msys isn't that compatible with unix (yet).

jannick0 · 2020-11-30T12:24:18Z

Many thanks for looking at that!

The entanglement with the "win" directory is only used to build the dde and registry extension. Although those 2 extensions are win32, they work fine with cygwin (and should work fine with msys2 too).

Would you be able to provide a pointer to where the tcl package compiles out of the box for CYGWIN including running the test cases? I would be courious to see the logs for config, build and tests.

Automatically determine --enable-64bit is a good idea, but it doesn't work yet together with the 'entaglement' with the "win" directory. Therefore I didn't take it over yet.

It could serve as global test to make --enable-64bit obsolete. I thought about that, too, when putting the test together, but I prefer to leave it with you to use the test globally. Potential additional test whether the macro INTPTR_MAX is really defined by stdint.h might be helpful for, e.g., very exotic or old systems, while the macro should usually exist, though.

It's a pity that so many testcases still fail. This shows that msys isn't that compatible with unix (yet).

Well, that might well be. On the other hand CYGWIN itself applies heavy patches to (cf. references in the first comment)

ignore the __CYGWIN__ branches in the code and
ignoring the winextension target in the win folder.
A similar patch MSYS2 does use. This suggests another interpretation. I am not advocating for any of the systems.

Again, this is why I would be intrigued to see how the tcl built on CYGWIN compiles (with winextensions) and tests out of the box. Any pointer to such a build for a most recent tcl package version? Many thanks.

nijtmans · 2020-12-01T10:19:36Z

out.txt

Here's the log when doing a cygwin "make test" for Tcl's unmodified core-8-6-branch (with -skip io-53.4.1, since this testcase fails on Cygwin too)

jannick0 · 2020-12-01T23:45:36Z

Thanks - this is interesting. It looks like that similar tests fail for CYGWIN and MSYS2, so they are not so far apart from each other in this context I believe.

Would it be possible to see how the tcl package build was configured, too. Maybe in a Github Action which would be the most transparent way I guess.

nijtmans · 2020-12-08T07:29:14Z

The number of testcases failing on msys2 is now below 100. One of them because of this commit (https://core.tcl-lang.org/tcl/info/921cc1eb98e51b90). The fossil repository (which this GIT repository is a mirror or) now has a "cygwin" branch which contains all official cygwin patches (undoing most of the #ifdef CYGWIN stuff). And there is a "msys2-fixes-v001" branch, which contains the changes from this PR rebased to the "cygwin" branch (so, based on 8.6 too).

Most test-failures I see seem to be caused by lack of support for links on Windows. On cygwin it's a little bit better.

Thanks for your contribution.

B.T.W.: Is fossil ported to msys2?

jannick0 · 2020-12-08T13:40:41Z

The number of testcases failing on msys2 is now below 100.

This is really good news - congratulations!

One of them because of this commit (https://core.tcl-lang.org/tcl/info/921cc1eb98e51b90).

I personally would use msys (or msys2) instead of msystem which would then be more in line with the unix nomenclature for MSYS2 animals.

Most test-failures I see seem to be caused by lack of support for links on Windows. On cygwin it's a little bit better.

This was exactly what I was expecting. The same thing for the sqlite testsuite on MSYS2.
Q: So would it be possible to have a tcl function which intrinsically checks at run-time if symbolic links work or not? (I am not sure if this gets into the realm of soft and hard links on Windows.) This function could then be used to test at check time if links work or not to decide if tests relying on links should be run or not.
See here a related suggestion for the sqlite testsuite. As far as I can see the ball is not rolling there yet.

B.T.W.: Is fossil ported to msys2?

Yes. NB: Call fossil either in the MINGW32 or MINGW64 shell (but not in the MSYS shell, though):

Note that there are the three shells MSYS, MINGW32 and MINGW64
info on the fossil package for, say, MINGW64; download the fossil package for MINGW64 like so: pacman -S mingw-w64-x86_64-fossil (NB: pacman can be called in any of the 3 shells).
how to use in Github Workflows CI and more detailed info

HTH - thanks again for your work.

jan.nijtmans and others added 30 commits September 25, 2020 14:26

Merge 8.7

42e1c69

Merge trunk

7bea794

Build Travis with Xcode 12 and 12u (Universal Apps)

fb163e8

Tweak xcode labels for Travis build

15f3c27

Merge 8.5

7dd8dc9

Merge 8.6

d42a401

Merge 8.7

37cd35c

Make Tcl compile warning-free using -Wshadow

7fd9fb3

Merge 8.6

0e66e2b

Merge 8.7

3abf8ac

Revert change that made test expr-20.2 fail.

3b36e1b

Restore change with correction.

c0ebda1

merge 8.7

d7d77f7

Update internal zlib channel type from TCL_CHANNEL_VERSION_3 to TCL_C…

d87f22f

…HANNEL_VERSION_5. Not actually a change, since supported procs are the same. So all internal channels have the same type

Merge-mark

d4c4f4f

Add -Wshadow flag to the compiler, so we will be notified when (accid…

04f7492

…ently) shadowing variable names

Merge 8.7

0daac00

Ticket [0063cbcada]: check http::geturl -headers parameter to be a dict.

b7c5a25

Remove wrong copy of test case http-3.2

038f813

Ticket [0063cbcada]: check http::geturl -headers parameter to be a dict

41ee2b2

Ticket [0063cbcada]: check http::geturl -headers parameter to be a dict

53ab0e8

Ticket [0063cbcada]: check http::geturl -headers parameter to be a dict

b1ba0b3

Ticket [0063cbcada]: From tcl 8.7 on, use "string is dict" instead "s…

428d063

…tring is list" & length %2 == 0 to check for a valid dict

Ticket [0063cbcada]: From tcl 8.7 on, use "string is dict" instead "s…

a6453b0

…tring is list" & length %2 == 0 to check for a valid dict

TIP #581 tweak: Don't report "slaves" as valid option for "interp"

bdad094

(slightly) better error-message for invalid http -headers option. Thi…

31adfea

…s works for plain 8.6 too

Merge 8.6

316cdba

Merge 8.7

3d47cfb

Merge 8.7

6f51eac

Fix -Wshadow warnings, when compiling with a C++ compiler

a2b001c

jan.nijtmans and others added 9 commits November 26, 2020 14:43

Get rid of "register" keyword, forbidden in c++20.

267a186

Fix some more warnings, discovered in c20/c++20 mode

Merge 8.6

c8bd621

Merge 8.7

75721f1

autoconf(unix): treat platform MSYS(2) similar to CYGWIN

7bb7ae8

* unix/tcl.m4: add 'MSYS_' whenever 'CYGWIN_' * unix/configure: same here.

tests(env.test): add env variable MSYSTEM to be ignored

d1adb11

The env variable MSYSTEM is used in the CYGWIN-like MSYS shell governing the underlying platform type.

autoconf(unix,win): remove redundant code block

7e088e2

The removed code block is generated by the autoconf (2.69) macro AC_ARG_ENABLE. So let's remove it since it works as an idempotent. * unix/tcl.m4: here. * unix/configure: same. * win/tcl.m4: here. * win/configure: same.

autoconf(unix): determine dynamically if CYGWIN platform is 64-bit

46caf2e

* unix/tcl.m4: - use cpp macro condition 'INTPTR_MAX == INT64_MAX' to portably check if platform is 64-bit. * unix/configure: same.

github workflow: add MSYS2 CI-build

fb59b77

This github workflow is meant to be copied to the windows workflow file. NB: Ignore io-53.4.1 which currently hangs.

nijtmans self-assigned this Nov 30, 2020

andreas-kupries force-pushed the main branch from 030ce31 to cfb135e Compare January 29, 2021 09:51

andreas-kupries force-pushed the main branch from baeaef1 to 9293112 Compare August 10, 2021 07:21

andreas-kupries force-pushed the main branch from a3659e3 to b714d26 Compare December 22, 2021 08:23

andreas-kupries force-pushed the main branch from ebde2c0 to 56bcf3d Compare January 17, 2023 08:25

andreas-kupries force-pushed the main branch 2 times, most recently from 2a5ffb4 to bc4ced9 Compare April 17, 2023 07:27

andreas-kupries force-pushed the main branch from 3649039 to aa4247d Compare May 3, 2023 07:39

andreas-kupries force-pushed the main branch from fe9832f to e10b5cb Compare July 15, 2023 07:26

andreas-kupries force-pushed the main branch from d49bf1f to 4cc6106 Compare July 30, 2024 07:21

andreas-kupries force-pushed the main branch 3 times, most recently from 335ca95 to 78e6f53 Compare August 27, 2024 07:20

andreas-kupries force-pushed the main branch 2 times, most recently from 0616c80 to 39c100c Compare August 31, 2024 07:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add github workflow for CYGWIN-like platform MSYS2 on Windows #9

add github workflow for CYGWIN-like platform MSYS2 on Windows #9

jannick0 commented Nov 29, 2020

nijtmans commented Nov 30, 2020 •

edited

Loading

jannick0 commented Nov 30, 2020

nijtmans commented Dec 1, 2020

jannick0 commented Dec 1, 2020

nijtmans commented Dec 8, 2020

jannick0 commented Dec 8, 2020

add github workflow for CYGWIN-like platform MSYS2 on Windows #9

Are you sure you want to change the base?

add github workflow for CYGWIN-like platform MSYS2 on Windows #9

Conversation

jannick0 commented Nov 29, 2020

nijtmans commented Nov 30, 2020 • edited Loading

jannick0 commented Nov 30, 2020

nijtmans commented Dec 1, 2020

jannick0 commented Dec 1, 2020

nijtmans commented Dec 8, 2020

jannick0 commented Dec 8, 2020

nijtmans commented Nov 30, 2020 •

edited

Loading