fix #404: guard against adapters with no options (#405)

tconbeer · Jan 11, 2024 · 873b7ce · 873b7ce
1 parent 3a63442
commit 873b7ce
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.
 -   Harlequin now loads immediately and connects to your database in the background ([#393](https://github.com/tconbeer/harlequin/issues/393)).
 -   Harlequin shows a loading indicator before the Data Catalog is hydrated for the first time ([#396](https://github.com/tconbeer/harlequin/issues/396)).
 
+### Bug Fixes
+
+-   Fixes a bug where `harlequin --config` would crash if configuring an adapter that declared no options.
+
 ## [1.9.2] - 2024-01-10
 
 ### Features

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -51,6 +51,7 @@ pre-commit = "^3.3.1"
 textual-dev = "^1.0.1"
 harlequin-postgres = "^0.2"
 harlequin-mysql = "^0.1.1"
+harlequin-odbc = "^0.1.1"
 
 [tool.poetry.group.static.dependencies]
 black = "^23.3.0"

diff --git a/src/harlequin/config_wizard.py b/src/harlequin/config_wizard.py
@@ -88,11 +88,15 @@ def _wizard() -> None:
         if adapter_cls.ADAPTER_OPTIONS is not None
         else []
     )
-    which = questionary.checkbox(
-        message="Which of the following adapter options would you like to set?",
-        choices=adapter_option_choices,
-        style=HARLEQUIN_QUESTIONARY_STYLE,
-    ).unsafe_ask()
+
+    if adapter_option_choices:
+        which = questionary.checkbox(
+            message="Which of the following adapter options would you like to set?",
+            choices=adapter_option_choices,
+            style=HARLEQUIN_QUESTIONARY_STYLE,
+        ).unsafe_ask()
+    else:
+        which = []
 
     adapter_options = {}
     if conn_str: