Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

%23 in URL interpreted as # #264

Open
ndsvw opened this issue May 23, 2023 · 2 comments
Open

%23 in URL interpreted as # #264

ndsvw opened this issue May 23, 2023 · 2 comments

Comments

@ndsvw
Copy link

ndsvw commented May 23, 2023

Steps:

  1. Create a file test.md with only this content: https://github.com/atinfo/awesome-test-automation/blob/master/c%23-test-automation.md
  2. Run markdown-link-check test.md

Expected:

  • No failure, because site exists and is online

Actual:

ERROR: 1 dead links found!
sscheib added a commit to sscheib/ansible-role-file_deployment that referenced this issue Apr 6, 2024
@sscheib
ci: Ignoring URLs with %23
00f623d 
Ignoring URLs with %23, as this leads to false positives with markdown-link-check - see
tcort/markdown-link-check#264
@sscheib sscheib mentioned this issue Apr 6, 2024
Merged
@erikbosch
Copy link

I noticed a similar problem for %2F (i.e. /), giving an error on the link below. Possibly same root cause, that the %2F is not kept but replaced.

https://github.com/eclipse-kuksa/kuksa-python-sdk/pkgs/container/kuksa-python-sdk%2Fkuksa-client

erikbosch added a commit to erikbosch/kuksa-actions that referenced this issue Jun 10, 2024
@erikbosch
Address bug in check-markdown-link
1aeaa6a 
It currently gives an error for links containing %2F, like:

https://github.com/eclipse-kuksa/kuksa-python-sdk/pkgs/container/kuksa-python-sdk%2Fkuksa-client

Probably same error as reported in tcort/markdown-link-check#264

Proposed workaround is to exclude links with % from check
@erikbosch erikbosch mentioned this issue Jun 10, 2024
Merged
SebastianSchildt pushed a commit to eclipse-kuksa/kuksa-actions that referenced this issue Jun 10, 2024
@erikbosch @SebastianSchildt
Address bug in check-markdown-link
2d3ac48 
It currently gives an error for links containing %2F, like:

https://github.com/eclipse-kuksa/kuksa-python-sdk/pkgs/container/kuksa-python-sdk%2Fkuksa-client

Probably same error as reported in tcort/markdown-link-check#264

Proposed workaround is to exclude links with % from check
@cc-stjm
Copy link

cc-stjm commented Oct 11, 2024

I think the underlying issue here is tcort/link-check#45 - discovered this myself earlier and it puts me off what is otherwise a very useful tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ndsvw @erikbosch @cc-stjm