Fix/list all events in previous events view #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🗃️ Add 15 new past events to seed data for testing
✨ Implement /past-events/count endpoint to get the count of past events
✨ Implement /past-events endpoint to retrieve past events with pagination
✅ Add tests for the two new API endpoints
otytlandsvik
requested changes
Nov 3, 2024
app/api/events.py
Outdated
| db = get_database(request) | ||
|
|
||
| # Get current UTC datetime | ||
| current_datetime = datetime.now(timezone.utc) |
There was a problem hiding this comment.
This endpoint uses timezone.utc, but none of the others do. This might lead to wrong results here
app/api/events.py
Outdated
| # Apply search filter according to role | ||
| search_filter = {"date": {"$lt": current_datetime}} | ||
| if token and token.role != Role.admin: | ||
| search_filter["public"] = True |
There was a problem hiding this comment.
I'm not sure this is leads to a valid mongodb query. You can copy the search filter logic from the get_past_events endpoint instead
app/api/events.py
Outdated
| """ Get last 10 events that have passed """ | ||
| def get_past_events(request: Request, token: AccessTokenPayload = Depends(optional_authentication), | ||
| skip: int = Query(0, ge=0), | ||
| limit: int = Query(10,ge=1,le=50)): |
There was a problem hiding this comment.
Like I commented on the frontend, another design here that might be simpler is to simply use a hardcoded limit, instead of allowing clients to supply it in the query parameters. If you choose to simplify it, remember to do it both on the api and the frontend.
This commit will: - Refactor the `get_past_events` endpoint to use a fixed query limit - Now uses localtime instead of utctime in `get_past_events` endpoint - Refactor the 'get_past_events' endpoint to use the same mongodb-query logic as the rest of the functions for consistency - Update pagination parameters in the test suite to reflect the new fixed limit and validate functionality. - Ensure tests verify filtering and pagination logic with updated query constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.