Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove tracking of admin pages #89

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

FredrikMorstad
Copy link
Member

Stop accepting /admin pages

Admin pages does not need tracking and can be filtered out

if "admin" in page:
# remove admin logs
return
res = db.pageVisitLog.insert_one({"timestamp": ts, "metaData": page})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing "visits": 1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not necessary as we counts the number of occurrences so visits only takes up space

Copy link
Contributor

@otytlandsvik otytlandsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredrikMorstad FredrikMorstad merged commit 1e8d70a into master Nov 25, 2023
1 check passed
@FredrikMorstad FredrikMorstad deleted the fix/remove-tracking-admin-pages branch November 25, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants