Feature/page view count #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikMorstad
force-pushed
the
feature/page-view-count
branch
3 times, most recently
from
f691525 to
98ab6ea
Compare
|
Good idea to keep that info off the event 'card'. How about placing it on the left below the admin menu? |
otytlandsvik
approved these changes
Nov 28, 2023
src/components/pages/events/eventPage/validEvent/ValidEvent.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/events/eventPage/validEvent/ValidEvent.tsx
Outdated
Show resolved
Hide resolved
src/components/pages/events/eventPage/validEvent/ValidEvent.tsx
Outdated
Show resolved
Hide resolved
Moved the view count to the left side and it looks better 👍 |
FredrikMorstad
force-pushed
the
feature/page-view-count
branch
from
98ab6ea to
6227bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Visit count on admin view for event page
Dependent on td-org-uit-no/tdctl-api#90
Fetches the number of vists on a page and displays
The design is a mvp and is open for ideas 💡