Add tdbytes info page and suggestions #283
Conversation
| lættis på. | ||
| </Text> | ||
| <Text> | ||
| Kontoret skal i utgangspunktet være åpent i skoletidene, men |
There was a problem hiding this comment.
Maybe change info text now that all IFI-students should have access to td-kontoret
| if (role === Roles.admin || role === Roles.kiosk_admin) { | ||
| fetchSuggestions(); | ||
| } else { | ||
| setErrMsg('Du har ikke de nødvendige rettighetene'); |
There was a problem hiding this comment.
Just a question. is it an error if I am on this page as a regular user? Shouldn't the fetch only happen if I have the right access and nothing else if I am a regular user?
There was a problem hiding this comment.
As this is the only kiosk_admin site so far, I think it's reasonable to do the auth check in the page instead of creating another route component to handle it
src/App.tsx
Outdated
| @@ -65,6 +67,8 @@ const App: React.FC = () => { | |||
| /> | |||
| <Route path="/about-us" component={AboutPage} /> | |||
| <Route path="/new-student" component={NewStudentsPage} /> | |||
| <Route path="/tdbytes/suggestions" component={SuggestionsPage} /> | |||
There was a problem hiding this comment.
Is this really an open route? isn't this only for members i.e PrivateRoute?
| const moveToLoginPage = () => { | ||
| history.push('/login'); | ||
| }; |
There was a problem hiding this comment.
if the suggestion route is moved to a privet route this can be removed as a the privateRoute sends an unauthorised user to login before redirecting the back to the desired destination. So redirecting to /suggestion automatically sends the user to login if not authenticated
There was a problem hiding this comment.
I'm thinking the TDBytes page should be viewable to anyone, also if they aren't logged in. Posting suggestions however should require login.
💎 Changes
Closes #274
✨ Added a tdBytes page
Displays some general info about the kiosk and office
Has a small form at the bottom to submit kiosk product suggestions
✨ Added a page to view kiosk product suggestions
Displays all suggestions in a table
🛂 Also added a new kiosk admin role, to allow members outside TD-Styret to view suggestions
Additional changes