Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn for geoms with showSelected=duration var but no key #146

Merged
merged 13 commits into from
May 8, 2016
Merged

Conversation

tdhock
Copy link
Owner

@tdhock tdhock commented Apr 1, 2016

if we use smooth transitions a key should be specified to ensure that those transitions are meaningful. the compiler can and should warn the user if the key should be specified, but is not.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 0.907% when pulling 792e246 on warn-no-key into b0a708d on master.

@tdhock
Copy link
Owner Author

tdhock commented Apr 8, 2016

aes(href) is working for geom_point but not for geom_polygon. The a elements are rendered but they do not have an href attribute. this is probably an easy fix for the renderer.

@tdhock
Copy link
Owner Author

tdhock commented Apr 8, 2016

TODO add a test that captures #147

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 0.907% when pulling f170343 on warn-no-key into b0a708d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 1.198% when pulling 48a6376 on warn-no-key into b0a708d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 0.899% when pulling 5437fb4 on warn-no-key into b0a708d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 1.198% when pulling 3e9d779 on warn-no-key into b0a708d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 1.198% when pulling 3e9d779 on warn-no-key into b0a708d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 0.899% when pulling 42bdb47 on warn-no-key into b0a708d on master.

@tdhock tdhock merged commit 6b1c9e5 into master May 8, 2016
@tdhock tdhock deleted the warn-no-key branch May 8, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants