Support commands defined or supplied in any case (fixes #3)

tdmalone · Aug 25, 2018 · 39bb344 · 39bb344
1 parent 36da8a2
commit 39bb344
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/helpers.js b/src/helpers.js
@@ -38,8 +38,10 @@ const extractCommand = ( message, commands ) => {
   let firstLocation = Number.MAX_SAFE_INTEGER,
       firstCommand;
 
+  const messageInLowerCase = message.toLowerCase();
+
   for ( const command of commands ) {
-    const location = message.indexOf( command );
+    const location = messageInLowerCase.indexOf( command.toLowerCase() );
     if ( -1 !== location && location < firstLocation ) {
       firstLocation = location;
       firstCommand = command;

diff --git a/tests/helpers.js b/tests/helpers.js
@@ -19,7 +19,9 @@ describe( 'extractCommand', () => {
   const commands = [
     'test-command',
     'something-else',
-    'another-command'
+    'another-command',
+    'UPPERCASE-COMMAND',
+    'Mixed-Case-Command'
   ];
 
   it( 'returns a valid command from a message containing only that command', () => {
@@ -57,7 +59,27 @@ describe( 'extractCommand', () => {
     expect( helpers.extractCommand( message, commands ) ).toBeFalse();
   });
 
-});
+  it( 'supports a command given in uppercase', () => {
+    const message = '<@U12345678> TEST-COMMAND';
+    expect( helpers.extractCommand( message, commands ) ).toEqual( 'test-command' );
+  });
+
+  it( 'supports a command given in mixed case', () => {
+    const message = '<@U12345678> Test-Command';
+    expect( helpers.extractCommand( message, commands ) ).toEqual( 'test-command' );
+  });
+
+  it( 'supports a command defined in uppercase', () => {
+    const message = '<@U12345678> uppercase-command';
+    expect( helpers.extractCommand( message, commands ) ).toEqual( 'UPPERCASE-COMMAND' );
+  });
+
+  it( 'supports a command defined in mixed case', () => {
+    const message = '<@U12345678> mixed-case-command';
+    expect( helpers.extractCommand( message, commands ) ).toEqual( 'Mixed-Case-Command' );
+  });
+
+}); // ExtractCommand.
 
 describe( 'extractPlusMinusEventData', () => {