Fixing issues noted by @ArthurChapman in comments on issue #189. Addi…

…ng leading zeros to tests. Fixing NOT_COMPLIANT out of range month 13.
tdwg · Oct 1, 2020 · ef70066 · ef70066
1 parent 7c49bc0
commit ef70066
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/tg2/core/testdata/testdata_VALIDATION_DAY_NOTSTANDARD.csv b/tg2/core/testdata/testdata_VALIDATION_DAY_NOTSTANDARD.csv
@@ -5,6 +5,8 @@
 " 1","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 1 is a valid value for dwc:day.]"
 "0","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 31 inclusive.]"
 "1st","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 31 inclusive.]"
+"01","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 1 is a valid value for dwc:day.]"
+"02","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 2 is a valid value for dwc:day.]"
 "-1","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 31 inclusive.]"
 "1.1","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 31 inclusive.]"
 "1.01","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 31 inclusive.]"

diff --git a/tg2/core/testdata/testdata_VALIDATION_MAXDEPTH_OUTOFRANGE.csv b/tg2/core/testdata/testdata_VALIDATION_MAXDEPTH_OUTOFRANGE.csv
@@ -1,6 +1,7 @@
 "dwc:maximumDepthInMeters","bdq:minimumValidDepthInMeters","bdq:maximumValidDepthInMeters","Response.Status","Response.Result","Response.Comment"
 100,0,11000,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 100 is in the range 0 to 11000 inclusive]"
 100,,,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 100 is in the default range 0 to 11000 inclusive]"
+0100,,,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 100 is in the default range 0 to 11000 inclusive]"
 200000,,,"RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 200000 is outside the default range 0 to 11000 inclusive]"
 0.4,,,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 0.4 is in the default range 0 to 11000 inclusive]"
 0,,,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 0 is in the default range 0 to 11000 inclusive]"

diff --git a/tg2/core/testdata/testdata_VALIDATION_MONTH_NOTSTANDARD.csv b/tg2/core/testdata/testdata_VALIDATION_MONTH_NOTSTANDARD.csv
@@ -4,6 +4,9 @@
 "1","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 1 is a valid value for dwc:month.]"
 " 1","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 1 is a valid value for dwc:month.]"
 "0","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 12 inclusive.]"
+"01","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 1 is a valid value for dwc:month.]"
+"02","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 2 is a valid value for dwc:month.]"
+"03","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 3 is a valid value for dwc:month.]"
 "1st","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 12 inclusive.]"
 "-1","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 12 inclusive.]"
 "1.1","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. provided value is not an integer in the range 1 to 12 inclusive.]"
@@ -36,9 +39,9 @@
 "10","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 10 is a valid value for dwc:month.]"
 11,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 11 is a valid value for dwc:month.]"
 "12","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 12 is a valid value for dwc:month.]"
-"13","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 13 is not a valid value for dwc:month.]"
-13,"RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 13 is not a valid value for dwc:month.]"
-" 13 ","RUN_HAS_RESULT","COMPLIANT","[any human readable explanation, e.g. 13 is not a valid value for dwc:month.]"
+"13","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 13 is not a valid value for dwc:month.]"
+13,"RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 13 is not a valid value for dwc:month.]"
+" 13 ","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 13 is not a valid value for dwc:month.]"
 "14","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 14 is not an integer in the range 1 to 12, and thus is not a valid value for dwc:month.]"
 "15","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 15 is not an integer in the range 1 to 12, and thus is not a valid value for dwc:month.]"
 "16","RUN_HAS_RESULT","NOT_COMPLIANT","[any human readable explanation, e.g. 16 is not an integer in the range 1 to 12, and thus is not a valid value for dwc:month.]"