Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix eslint #51

wants to merge 2 commits into from

Conversation

danielart
Copy link
Collaborator

Fix eslint on examples folder
Removed custom eslint config on api-list
split script to format code teaful/examples

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x ] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
split script to format code between teaful and examples folder
remove custom eslint rules on api-list example

Which issue (if any) does this pull request address?
error running format script due to custom eslint rules on example api-list

Is there anything you'd like reviewers to focus on?

Fix eslint on examples folder
Removed custom eslint config on api-list
split script to format code teaful/examples
@danielart danielart requested a review from aralroca November 25, 2021 20:17
@danielart danielart self-assigned this Nov 25, 2021
Copy link
Collaborator

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that jsx is missing inside eslint for the example to work.

image

package.json Outdated Show resolved Hide resolved
Co-authored-by: Aral Roca Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants