Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.75 #352

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Bump MSRV to 1.75 #352

merged 1 commit into from
Feb 11, 2024

Conversation

dbrgn
Copy link
Collaborator

@dbrgn dbrgn commented Feb 4, 2024

For clap v4 (#298), we need a higher MSRV, currently at least Rust 1.64.

Our MSRV policy is:

When publishing a tealdeer release, the Rust version required to build it should be stable for at least a month.

I'd suggest to jump to 1.75. It's the current stable, released on December 28, and contains the "async fn in traits" change which makes it a potential synchronization point for libraries.

@niklasmohrin
Copy link
Collaborator

I think we should stay at 1.64 until we need a higher version. Are there any benefits to upgrading beyond that?

I am just thinking about something like the Debian package which maybe still has an old Rust version

@dbrgn
Copy link
Collaborator Author

dbrgn commented Feb 8, 2024

Are there any benefits to upgrading beyond that?

As long as we can bump the required Rust version with any new release, probably not. (Debian would be free to use an older version though, as long as it works.)

PR updated to 1.64.

Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can bump msrv freely (within reason and while adhering to our policy) between releases in PRs that need it.

If we would want to be strict about it, we could make semver major releases every time, but I feel that for us as a binary crate it is not as important as for libraries - maybe that's foolish though

@dbrgn dbrgn merged commit 2e731d7 into main Feb 11, 2024
9 checks passed
@dbrgn dbrgn deleted the msrv-1.75 branch February 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants