fix(DEV-11506): prevent incorrect rendering of images in <FileViewer />
😶🌫️
#133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an image was selected instead of a PDF for an invoice, the
PDFObject.embed()
function was still being called, even though the PDF container wasn't rendered. This caused the entire page content to be replaced with the image inside an iframe, as theref
wasn't properly set.Solution
We've refactored the
FileViewer
component to correctly handle different file types, particularly distinguishing between PDFs and images.Changes
PDFObject.embed()
calls for non-PDF filesPDFFileViewer
component<img />
tag with appropriate stylingImpact
Testing
Please test the following scenarios: