[WEBRTC-2421] [feat] Migrate SipCredentialsViewController to SwiftUI #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created new SwiftUI views: - SipCredentialsView (main view) - SipCredentialRow (list item) - SipCredentialHeader - Updated SipCredentialsViewController to use SwiftUI - Removed legacy UIKit files - Maintained all existing functionality
- Rename header to 'Existing Profiles' - Add close button and 'Add new profile' button - Update colors and styles according to design - Add bottom Cancel/Confirm buttons - Improve selection logic - Remove divider lines between sections
…tialHeader to match Figma design.
…entialView is visible the list of available credentials will be displayed
…d Caller ID number and Caller Name inputs
…scroll on small screens
…allerName and callerNumber
gbattistel
changed the title
Oliver-Zimmerman
approved these changes
Jan 22, 2025
isaacakakpo1
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEBRTC-2421 [feat] Migrate SipCredentialsViewController to SwiftUI
Description
Migrated the SipCredentialsViewController from UIKit to SwiftUI while maintaining all existing functionality.
Changes
Functionality Preserved
Jira: WEBRTC-2421
video_2025-01-21_17-54-26.mp4