Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENGDESK-37644): Fix CallKit speaker button inconsistency #158

Closed
wants to merge 1 commit into from

Conversation

ai-swe-agent
Copy link

Description

Fixes the issue with CallKit speaker button state inconsistency by implementing proper audio session management and route change monitoring.

Changes

  1. Updated AVAudioSession configuration:

    • Added proper audio session category and mode settings
    • Enabled Bluetooth and mixing options
    • Set optimal buffer duration and sample rate
  2. Enhanced speaker/earpiece handling:

    • Added proper audio session locking
    • Improved error handling and logging
    • Added UI state notifications
  3. Added audio route change monitoring:

    • Automatic speaker state updates
    • Proper cleanup on disconnect
    • Improved CallKit integration

Testing

To test this fix:

  1. Make or receive a call with CallKit enabled
  2. Lock the screen to show the CallKit UI
  3. Toggle the speaker button
  4. Verify that:
    • The speaker state changes correctly
    • The UI updates to reflect the current state
    • The state persists after unlocking/locking the screen

Fixes: ENGDESK-37644

- Updated AVAudioSession configuration with proper settings
- Enhanced speaker/earpiece handling with proper locking
- Added audio route change monitoring for CallKit integration
- Improved error handling and logging
- Added UI state notifications for audio route changes

Fixes: ENGDESK-37644
@gbattistel
Copy link
Collaborator

Not working as expected. Closing

@gbattistel gbattistel closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants