Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBRTC-2332] [INIT] Demo App Improvement #163

Merged
merged 55 commits into from
Jan 30, 2025
Merged

Conversation

gbattistel
Copy link
Collaborator

@gbattistel gbattistel commented Jan 29, 2025

WEBRTC-2332 [INIT] Demo App Improvement

Migration to SwiftUI & UI Update

Changes:

  • Migrated the UI from UIKit to SwiftUI.
  • Updated the entire app's UI to align with the new design, improving the overall user experience.
  • Fixed a synchronization issue between the microphone and speaker states during a call, ensuring they stay in sync between the CallKit screen and the app’s UI.

Incoming call and Active call flow:

  • Logging in using a SIP credential and a Push Notification token. (Check from 00:15)
  • Closing the app to test receiving a push notification while the app is closed.
  • Receiving a push notification and displaying the incoming CallKit notification screen.
  • Answering the call, which opens the app with the Call Active screen.
  • From 00:45 to 01:10, I toggle the microphone and speaker buttons to show that the CallKit active call screen remains - - - synchronized with the app's UI states and vice versa.
Screen.Recording.2025-01-29.at.11.14.12.AM.mov

Add new sip credential

IMG_1622.MP4

Delete credentials

IMG_1623.MP4

gbattistel and others added 30 commits January 17, 2025 10:06
- Update launch screen:
  * Change background color to #00E3AA
  * Replace logo-white with telnyx-icon
  * Update constraints for centered icon

- Add SwiftUI splash screen:
  * White background with centered telnyx-logo
  * 2-second display duration
  * Smooth transition to main screen
[iOS] Splash Screen and App Icon Adjustments - WEBRTC-2425
- Created new SwiftUI views:
  - SipCredentialsView (main view)
  - SipCredentialRow (list item)
  - SipCredentialHeader
- Updated SipCredentialsViewController to use SwiftUI
- Removed legacy UIKit files
- Maintained all existing functionality
- Rename header to 'Existing Profiles'
- Add close button and 'Add new profile' button
- Update colors and styles according to design
- Add bottom Cancel/Confirm buttons
- Improve selection logic
- Remove divider lines between sections
…entialView is visible the list of available credentials will be displayed
[WEBRTC-2421] [feat] Migrate SipCredentialsViewController to SwiftUI
…entation from ViewController to HomeViewController
[WEBRTC-2421] [WEBRTC-2423] Profile Views and HomeView
…e HomeView in sync after connecting in background when answering a call
Copy link
Collaborator

@Oliver-Zimmerman Oliver-Zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my iPhone SE and looks and works great!

Only minor thing I noticed is that deleting a credential from the bottom sheet doesn't seem to work? Although perhaps that is just because the icon is so small on my screen?

@gbattistel
Copy link
Collaborator Author

Tested on my iPhone SE and looks and works great!

Only minor thing I noticed is that deleting a credential from the bottom sheet doesn't seem to work? Although perhaps that is just because the icon is so small on my screen?

Creds can be removed by doing a long press over the Trash icon. I did that to avoid deleting them by mistake

@gbattistel gbattistel merged commit 6019e86 into main Jan 30, 2025
1 check passed
@gbattistel gbattistel deleted the init/WEBRTC-2332-app branch January 30, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants