feat: set codec preferences on answer

team-telnyx · Jun 10, 2024 · fe4258b · fe4258b
1 parent 946649f
commit fe4258b
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/packages/js/src/Modules/Verto/webrtc/BaseCall.ts b/packages/js/src/Modules/Verto/webrtc/BaseCall.ts
@@ -274,6 +274,9 @@ export default abstract class BaseCall implements IWebRTCCall {
         customHeaders: params.customHeaders,
       };
     }
+    if (params.preferred_codecs?.length > 0) {
+      this.options.preferred_codecs = params.preferred_codecs;
+    }
 
     this.peer = new Peer(PeerType.Answer, this.options, this.session);
     await this.peer.iceGatheringComplete.promise;

diff --git a/packages/js/src/Modules/Verto/webrtc/Peer.ts b/packages/js/src/Modules/Verto/webrtc/Peer.ts
@@ -398,11 +398,11 @@ export default class Peer {
   }
 
   private _setAudioCodec = (transceiver: RTCRtpTransceiver) => {
-    if (!this.options.codecs || this.options.codecs.length === 0) {
+    if (!this.options.preferred_codecs || this.options.preferred_codecs.length === 0) {
       return;
     }
     if (transceiver.setCodecPreferences) {
-      return transceiver.setCodecPreferences(this.options.codecs);
+      return transceiver.setCodecPreferences(this.options.preferred_codecs);
     }
   };
   /** Workaround for ReactNative: first time SDP has no candidates */

diff --git a/packages/js/src/Modules/Verto/webrtc/interfaces.ts b/packages/js/src/Modules/Verto/webrtc/interfaces.ts
@@ -47,7 +47,7 @@ export interface IVertoCallOptions {
   customHeaders?: Array<{ name: string; value: string }>;
   debug?: boolean;
   debugOutput?: 'socket' | 'file';
-  codecs?: RTCRtpCodecCapability[];
+  preferred_codecs?: RTCRtpCodecCapability[];
 }
 
 export interface IStatsBinding {
@@ -57,6 +57,7 @@ export interface IStatsBinding {
 
 export interface AnswerParams {
   customHeaders?: Array<{ name: string; value: string }>;
+  preferred_codecs?: Array<RTCRtpCodecCapability>;
 }
 
 export interface IWebRTCCall {

diff --git a/packages/js/src/utils/interfaces.ts b/packages/js/src/utils/interfaces.ts
@@ -186,6 +186,21 @@ export interface ICallOptions {
    * Add custom headers to the INVITE and ANSWER request.
    */
   customHeaders?: { name: string; value: string }[];
+
+  /**
+   * Enable debug mode for this call.
+   */
+  debug?: boolean;
+
+  /**
+   * Output debug logs to a file.
+   */
+  debugOutput?: 'socket' | 'file';
+
+  /**
+   * Preferred codecs for the call.
+   */
+  preferred_codecs?: RTCRtpCodecCapability[];
 }
 
 /**