Refactor/combine #44
Merged
Refactor/combine #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviio
reviewed
Feb 11, 2017
src/storage/RuntimeError.ts
Outdated
| () => new ReactiveDBError(`Token cannot be combined.`) | ||
| export const TOKEN_CONCAT_ERR = | ||
| (msg?: string) => { | ||
| const errMsg = `Token cannot be concat ${ msg ? `due to: ${ msg }` : '' }` |
There was a problem hiding this comment.
'Token cannot be concated' + `${ msg ? ' due to: ' + msg : '' }.`
Saviio
reviewed
Feb 11, 2017
| } | ||
|
|
||
| concat(... selectMetas: Selector<T>[]): Selector<T> { | ||
| const equal = selectMetas.every(m => |
There was a problem hiding this comment.
consider:
SELECT * FROM TABLE WHERE id >= 0 SKIP 1 LIMIT 10
SELECT * FROM TABLE WHERE id >= 0 SKIP 2 LIMIT 20
...these queries will violate constraint of concat method, maybe we should add a term to check if skip mod limit is equal to 0
There was a problem hiding this comment.
limit should be equal here
Saviio
reviewed
Feb 11, 2017
src/storage/Selector.ts
Outdated
| const [ meta ] = metaDatas | ||
| const skips = metaDatas | ||
| .map(m => m.skip) | ||
| .sort() |
There was a problem hiding this comment.
consider:
SELECT * FROM TABLE WHER id >= 0 SKIP 10 LIMIT 10
SELECT * FROM TABLE WHER id >= 0 SKIP 20 LIMIT 10
SELECT * FROM TABLE WHER id >= 0 SKIP 30 LIMIT 10
...
SELECT * FROM TABLE WHER id >= 0 SKIP 100 LIMIT 10after sort => [10, 100, 20, 30, ...]
There was a problem hiding this comment.
这边 skip 是数字不是字符串吧？
private skip?: number
Brooooooklyn
force-pushed
the
refactor/combine
branch
from
9281902 to
8a0c4aa
Compare
Saviio
force-pushed
the
refactor/combine
branch
from
cdbee30 to
c5d88e8
Compare
Saviio
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
重新定义
combine并将其重命名为concat，老的combine实现保留。Related
#5