Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): 补充简单的 errors 字段处理机制 #551

Merged
merged 1 commit into from
Sep 30, 2018
Merged

fix(graphql): 补充简单的 errors 字段处理机制 #551

merged 1 commit into from
Sep 30, 2018

Conversation

chuan6
Copy link
Contributor

@chuan6 chuan6 commented Sep 30, 2018 •
edited
Loading

  • 在对应项目中试跑，确认没破坏当前基本行为。

这里的实现，粗暴地在后端提供了 errors 字段后就放弃 data 字段可能存在的有用数据。接下来，应该支持通过解析 errors 里 path 字段的信息，来支持 data 字段数据的部分可用性。#552

@chuan6 chuan6 requested a review from Saviio September 30, 2018 04:29
@chuan6 chuan6 self-assigned this Sep 30, 2018
@coveralls
Copy link

coveralls commented Sep 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 95.619% when pulling 895e8a7 on fix/graphql-errors into b54c1ad on release.

Saviio
Saviio approved these changes Sep 30, 2018
View reviewed changes
Copy link
Collaborator

@Saviio Saviio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuan6 chuan6 merged commit 0fc185f into release Sep 30, 2018
@chuan6 chuan6 deleted the fix/graphql-errors branch September 30, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviio Saviio Saviio approved these changes

Assignees

@chuan6 chuan6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuan6 @coveralls @Saviio