Fix desc order in paginate. #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order desc was sorting per page, not like real pagination, now it's working with me well.
That's better, the perv if the paginate 20 and last page has 4 results won't get them.
There is changes i don't understand it, but it works to me like in charm, get all IDs then order them in paginate, no more "rsort" or something else.
But i don't understand "keyBy($model->getKeyName())", if my pagination IDs is:
10
9
3
By "keyBy($model->getKeyName());" turns to:
3
9
10
So i deleted it and the:
return $models->newCollection($results['ids'])->map(function ($hit) use ($models) {
if (isset($models[$hit])) {
return $models[$hit];
}
})->filter()->values();
too, and it's working now, working too if your pagination not in default name "page".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order desc was sorting per page, not like real pagination, now it's working with me well.
fix for #260