Merge pull request #53 from techdivision/pac-129--refactor-override-i…

…mages PAC-129 - Refactor override images option
techdivision · Aug 24, 2020 · 71bd0ce · 71bd0ce
2 parents eb45ad9 + 3dfbbd9
commit 71bd0ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Subjects/OptionSubject.php b/src/Subjects/OptionSubject.php
@@ -76,10 +76,8 @@ public function setUp($serial)
         }
 
         // initialize the flag whether to override images or not
-        // @todo https://github.com/techdivision/import/issues/181
-        //       Create new constant ConfigurationKeys::OVERRIDE_IMAGES for future release
-        if ($this->getConfiguration()->hasParam('override-images')) {
-            $this->setOverrideImages($this->getConfiguration()->getParam('override-images'));
+        if ($this->getConfiguration()->hasParam(ConfigurationKeys::OVERRIDE_IMAGES)) {
+            $this->setOverrideImages($this->getConfiguration()->getParam(ConfigurationKeys::OVERRIDE_IMAGES));
         }
 
         // initialize media directory => can be absolute or relative

diff --git a/src/Utils/ConfigurationKeys.php b/src/Utils/ConfigurationKeys.php
@@ -42,4 +42,11 @@ class ConfigurationKeys extends \TechDivision\Import\Utils\ConfigurationKeys
      * @var string
      */
     const COPY_IMAGES = 'copy-images';
+
+    /**
+     * Name for the column 'override-images'.
+     *
+     * @var string
+     */
+    const OVERRIDE_IMAGES = 'override-images';
 }