Added an id method to all message structs #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
reviewed
May 9, 2024
| @@ -351,6 +351,15 @@ fn render_message(mut w: impl Write, config: &Config<'_>, msg: &Message, dbc: &D | |||
| writeln!(&mut w, "}}")?; | |||
| writeln!(w)?; | |||
|
|
|||
| writeln!(&mut w, "/// Access message id")?; | |||
| writeln!(&mut w, "pub fn id(&self) -> u32 {{",)?; | |||
There was a problem hiding this comment.
Suggested change
| writeln!(&mut w, "pub fn id(&self) -> u32 {{",)?; | |
| writeln!(&mut w, "pub fn message_id(&self) -> u32 {{",)?; |
For consistency with the constant name?
| writeln!(&mut w, "pub fn id(&self) -> u32 {{",)?; | ||
| { | ||
| let mut w = PadAdapter::wrap(&mut w); | ||
| writeln!(&mut w, "Self::MESSAGE_ID & 0x1FFF_FFFF")?; |
There was a problem hiding this comment.
Just curious, why does it need the bitwise AND? If MESSAGE_ID is bigger than 29-bits then shouldn't it fail somewhere else?
killercup
reviewed
May 13, 2024
I can't speak for @JoNil, but what I was hoping to work towards is defining a trait over all messages that lets you access |
|
That’s a good idea, I’d merge in this trait :) this will add a teeny tiny
bit of a runtime crate though which we’d need to add as a dependency.
(Reminds me of #35)
…On Tue, 14 May 2024 at 01:09, Angus Gratton ***@***.***> wrote:
What's the value of this over accessing the public constant?
I can't speak for @JoNil <https://github.com/JoNil>, but what I was
hoping to work towards is defining a trait over all messages that lets you
access message_id and raw. With a goal to building things like a send<impl
that_trait>(&msg) function that sends an arbitrary message struct to a
CAN controller, for example.
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAE4XZ4XRNXABIMXDIHHQTZCFB4NAVCNFSM6AAAAABHM5RWXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYHE2TMMBTHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
#82 adds impls for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.