🐛 fixed connecting with empty MySQL password #128
Conversation
null password was being converted by str() into a literal string "None"
WalkthroughThe changes in this pull request focus on the constructor of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/sqlite3_to_mysql/transporter.py (1)
71-71: LGTM! Consider optimising the password handling.The fix correctly resolves the regression with empty MySQL passwords. However, we can optimise the code to avoid duplicate dictionary lookups.
Consider this minor optimisation:
- self._mysql_password = str(kwargs.get("mysql_password")) if kwargs.get("mysql_password") else None + mysql_password = kwargs.get("mysql_password") + self._mysql_password = str(mysql_password) if mysql_password else None
|
Thanx again! 😇 Would it be too much to ask to add a test for this? I mean, it's how this flew under the radar to beging with 🙈 |
techouse
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 8 8
Lines 664 664
=======================================
Hits 592 592
Misses 72 72 ☔ View full report in Codecov by Sentry. |
Description
This fixes a regression introduced in 9efa266, which caused the transporter to try to connect with a literal string "None" as the password if password parameter wasn't passed (
str(kwargs.get("mysql_password"))convertsNoneto a string"None"). I've reverted this specific line to the old version withif else.Type of change
How Has This Been Tested?
Tested with my local database, connecting with an empty password.
Checklist: